j.foucher/PS_Ballistics
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix retrace OwnerSafe bug and restore debug trace colors

Browse Source 
Save and restore OwnerSafe state during retrace to prevent the bullet
from hitting the owner's actors when replaying a previous trace where
OwnerSafe was true. Also fix debug DrawDebugLine in Trace.cpp to use
proper velocity-based colors instead of hardcoded values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
j.foucher 2026-03-13 19:32:43 +01:00
parent 9b9c5254db
commit 669b65a30f
7 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
Unreal/Content/PACKS/Blueprints/EasyBallistics/Player/player.uasset
View File

Binary file not shown.

BIN
Unreal/Content/PACKS/Blueprints/EasyBallistics/bullet/bullet_tracer.uasset
View File

Binary file not shown.

BIN
Unreal/Plugins/EasyBallistics/Binaries/Win64/UnrealEditor-EasyBallistics.dll
View File

Binary file not shown.

BIN
Unreal/Plugins/EasyBallistics/Binaries/Win64/UnrealEditor-EasyBallistics.pdb
View File

Binary file not shown.

3
Unreal/Plugins/EasyBallistics/Source/EasyBallistics/Private/EBBullet.cpp
View File

@ -64,6 +64,8 @@ void AEBBullet::Step(float DeltaTime) {
if (Retrace && CanRetrace) { if (Retrace && CanRetrace) {
//time travel //time travel
bool SavedOwnerSafe = OwnerSafe;
OwnerSafe = LastTraceOwnerSafe;
float remainingTime = LastTraceDelta; float remainingTime = LastTraceDelta;
int remainingSteps = MaxTracesPerStep; int remainingSteps = MaxTracesPerStep;
FVector PreviousVelocity = LastTracePrevVelocity; FVector PreviousVelocity = LastTracePrevVelocity;
@ -87,6 +89,7 @@ void AEBBullet::Step(float DeltaTime) {
remainingSteps -= 1; remainingSteps -= 1;
if (remainingTime > 0.0f) { sendUpdate = true; }; if (remainingTime > 0.0f) { sendUpdate = true; };
} while (remainingTime > 0.0f && remainingSteps > 0); } while (remainingTime > 0.0f && remainingSteps > 0);
OwnerSafe = SavedOwnerSafe;
} }
CanRetrace = false; CanRetrace = false;

7
Unreal/Plugins/EasyBallistics/Source/EasyBallistics/Private/Trace.cpp
View File

@ -95,7 +95,8 @@ float AEBBullet::Trace(FVector start, FVector PreviousVelocity, float delta, TEn
#ifdef WITH_EDITOR #ifdef WITH_EDITOR
if (DebugEnabled) { if (DebugEnabled) {
DrawDebugLine(GetWorld(), start, HitResult.Location, FColor::Blue, false, DebugTrailTime, 0, 3.0f); FColor DebugColor = FColor::MakeRedToGreenColorFromScalar(Velocity.Size() / MuzzleVelocityMax);
DrawDebugLine(GetWorld(), start, HitResult.Location, DebugColor, false, DebugTrailTime, 0, DebugTrailWidth);
}; };
#endif #endif
@ -178,6 +179,7 @@ float AEBBullet::Trace(FVector start, FVector PreviousVelocity, float delta, TEn
LastTraceDelta = delta; LastTraceDelta = delta;
LastTracePrevVelocity = PreviousVelocity; LastTracePrevVelocity = PreviousVelocity;
LastTraceVelocity = Velocity; LastTraceVelocity = Velocity;
LastTraceOwnerSafe = OwnerSafe;
} }
SetActorLocation(start + TraceDistance); SetActorLocation(start + TraceDistance);
@ -187,7 +189,8 @@ float AEBBullet::Trace(FVector start, FVector PreviousVelocity, float delta, TEn
#ifdef WITH_EDITOR #ifdef WITH_EDITOR
if (DebugEnabled) { if (DebugEnabled) {
DrawDebugLine(GetWorld(), start, start + TraceDistance, FColor::Magenta, false, DebugTrailTime, 0, 3.0f); FLinearColor Color = GetDebugColor(Velocity.Size() / ((MuzzleVelocityMin + MuzzleVelocityMax)*0.5f));
DrawDebugLine(GetWorld(), start, start + TraceDistance, Color.ToFColor(true), false, DebugTrailTime, 0, 0);
} }
} }
#endif #endif

1
Unreal/Plugins/EasyBallistics/Source/EasyBallistics/Public/EBBullet.h
View File

@ -208,6 +208,7 @@ private:
float LastTraceDelta; float LastTraceDelta;
FVector LastTraceVelocity; FVector LastTraceVelocity;
FVector LastTracePrevVelocity; FVector LastTracePrevVelocity;
bool LastTraceOwnerSafe = false;
bool IsRecycled; bool IsRecycled;